Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36207 )
Change subject: ec/google/chromeec: Add EC driver support for software sync ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36207/7/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/36207/7/src/ec/google/chromeec/ec.c... PS7, Line 1474: for (i = 0; i < resp.num_ports; i++) { : struct ec_params_usb_pd_get_mode_request params; : struct ec_params_usb_pd_get_mode_response resp2; : int svid_idx = 0; : : do { : /* Reset cmd in each iteration in case : google_chromeec_command changes it. */ : params.port = i; : params.svid_idx = svid_idx; : cmd.cmd_code = EC_CMD_USB_PD_GET_AMODE; : cmd.cmd_version = 0; : cmd.cmd_data_in = ¶ms; : cmd.cmd_size_in = sizeof(params); : cmd.cmd_data_out = &resp2; : cmd.cmd_size_out = sizeof(resp2); : cmd.cmd_dev_index = 0; : : if (google_chromeec_command(&cmd) < 0) : return -1; : if (resp2.svid == svid) : return 1; : svid_idx++; : } while (resp2.svid); Was this supposed to be put into the previous CL?