Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28392 )
Change subject: mb/lenovo: dGPU power handling on T430, T530 ......................................................................
mb/lenovo: dGPU power handling on T430, T530
Enable dGPU power handling on Lenovo ThinkPad T430, T530 via PMH7 register 0x50.
Although there's no Thinker-1 chip on these models according to schematics, dGPU power control via PMH7 works the same as on T420/T520, so they can be considered Thinker-1-compatible.
It can be tested from linux userspace using util/pmh7tool.
To turn dGPU power off: pmh7tool -c 0x50 7 pmh7tool -c 0x50 3
To turn it on: pmh7tool -s 0x50 3 pmh7tool -s 0x50 7
To check whether it is on (bash): reg=0x$(pmh7tool -r 0x50) echo "$(( (( reg & 0x08 )) >> 3 ))" or just `pmh7tool -b 0x50 3` with https://review.coreboot.org/#/c/coreboot/+/28388/
Tested on ThinkPad W530.
Change-Id: Ieab1a33b3c680c757cc0999660b5cb7e122474cc Signed-off-by: Evgeny Zinoviev me@ch1p.com Reviewed-on: https://review.coreboot.org/28392 Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lenovo/t430/devicetree.cb M src/mainboard/lenovo/t530/variants/t530/devicetree.cb M src/mainboard/lenovo/t530/variants/w530/devicetree.cb 3 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved
diff --git a/src/mainboard/lenovo/t430/devicetree.cb b/src/mainboard/lenovo/t430/devicetree.cb index d466b36..5eb92bc 100644 --- a/src/mainboard/lenovo/t430/devicetree.cb +++ b/src/mainboard/lenovo/t430/devicetree.cb @@ -167,7 +167,7 @@ register "has_backlight_gpio" = "0" register "has_dgpu_power_gpio" = "0"
- register "has_thinker1" = "0" + register "has_thinker1" = "1" end chip drivers/pc80/tpm device pnp 0c31.0 on end diff --git a/src/mainboard/lenovo/t530/variants/t530/devicetree.cb b/src/mainboard/lenovo/t530/variants/t530/devicetree.cb index 0da05e0..4dcdc9d 100644 --- a/src/mainboard/lenovo/t530/variants/t530/devicetree.cb +++ b/src/mainboard/lenovo/t530/variants/t530/devicetree.cb @@ -157,7 +157,7 @@ register "has_backlight_gpio" = "0" register "has_dgpu_power_gpio" = "0"
- register "has_thinker1" = "0" + register "has_thinker1" = "1" end end # LPC bridge device pci 1f.2 on end # SATA Controller 1 diff --git a/src/mainboard/lenovo/t530/variants/w530/devicetree.cb b/src/mainboard/lenovo/t530/variants/w530/devicetree.cb index d9d9df5..7a72b26 100644 --- a/src/mainboard/lenovo/t530/variants/w530/devicetree.cb +++ b/src/mainboard/lenovo/t530/variants/w530/devicetree.cb @@ -179,7 +179,7 @@ register "has_backlight_gpio" = "0" register "has_dgpu_power_gpio" = "0"
- register "has_thinker1" = "0" + register "has_thinker1" = "1" end end device pci 1f.2 on # SATA Controller 1