[coreboot-gerrit] Change in coreboot[master]: vboot: remove VBOOT_SAVE_RECOVERY_REASON_ON_REBOOT option

[Joel Kitching (Code Review)]

Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38780 )

Change subject: vboot: remove VBOOT_SAVE_RECOVERY_REASON_ON_REBOOT option
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38780/2/src/security/vboot/bootmode... 
File src/security/vboot/bootmode.c:

https://review.coreboot.org/c/coreboot/+/38780/2/src/security/vboot/bootmode... 
PS2, Line 65: 	if (get_recovery_mode_switch())
> Yes, all those cases you listed are running after verstage (at least for STARTS_IN_BOOTBLOCK which s […]

Currently the assertion that would be triggered is inside vboot_get_context():

assert(verification_should_run());

Do you mean that we need something clearer?  If so, probably we could just clarify in vboot_get_context() rather than each separate function for retrieving vboot modes?  Something like:

if (!verification_should_run())
    die("vboot context should not be retrieved before verstage has run")