Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32375 )
Change subject: postcar_loader: Use size_t
......................................................................
Patch Set 4:
(1 comment)
W
https://review.coreboot.org/#/c/32375/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32375/4//COMMIT_MSG@8
PS4, Line 8:
: To make it easier to pop arguments from stack use size_t instead of int.
: This is a noop on x86_32.
I'm not very well aware of how amd64 works but why is using 32bit math/ stack pop not an option?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32375
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I226f79eaea425229eb2e3d9b9a312c9bf47d3b6a
Gerrit-Change-Number: 32375
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 21 Apr 2019 09:07:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment