Name of user not set #1002873 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39893 )
Change subject: Documentation: Add proposal for firmware unit testing ......................................................................
Patch Set 3:
(7 comments)
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... File Documentation/technotes/2020-03-unit-testing-coreboot.md:
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... PS3, Line 135: They offer similar functionality as Unity, while at the same time don’t seem
If you decide to keep this section, indent this paragraph. […]
Indeed, I haven't notice this in the generated doc. Actually I don't like the way Sphinx is generating bullet lists in html. I mean, description for a bullet can be easily mistaken for usual paragraph text. This text is also very close to the consecutive bullet, I would prefer it to stick closer to upper one.
That being said, eventually I will remove completely this paragraph, see my reply below.
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... PS3, Line 140: Another one which is rather widely used, however it doesn't have good support
Indent here if keeping this section
As above.
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... PS3, Line 130: Three more frameworks should be mentioned here, however they weren't tried : within coreboot: : * [Check](https://libcheck.github.io/check/) : * [Criterion](https://github.com/Snaipe/Criterion/) : : They offer similar functionality as Unity, while at the same time don’t seem : to have similarly active communities. : : * [CUnit](http://cunit.sourceforge.net/) : : Another one which is rather widely used, however it doesn't have good support : for mocking. : : If anyone has good experience with some framework which is not listed above, it : will be highly appreciated to give a note about this to the author. In such : cases, it may be necessary to investigate such tools deeply and then reconsider : the decision.
I'm not sure this section adds value any more. […]
Yes, I agree. This is a leftover from my initial goal - to start discussions within coreboot community. Will remove this paragraph and also other parts, which bring no value in having them upstreamed. Your proposal sounds good.
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... PS3, Line 254: ├── build
I know that 'build' will get listed first because of alphabetical order, but I suggest moving it to […]
Makes sense.
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... PS3, Line 285: replaces
replace
Done
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... PS3, Line 285: one
headers
Done
https://review.coreboot.org/c/coreboot/+/39893/3/Documentation/technotes/202... PS3, Line 298: test
tests […]
Done