Attention is currently required from: Jason Glenesk, Raul Rangel, Jason Nien, Matt DeVillier, Paul Menzel, Fred Reitberger, Karthik Ramasubramanian.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67188 )
Change subject: amd: Convert dptc_enable to bool
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/zork/variants/morphius/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/67188/comment/302ce9e7_5bc3d103
PS5, Line 33: true
You need to quote this don't you?
No, it doesn't need to be quoted. These values work correctly as raw `true`/`false` without quotes.
Specifically, I've verified that `true` outputs the necessary methods, while they are not present with `false` (no quotes on either):
`SSDT1.dsl`
```
Scope (_SB)
{
Method (DDEF, 0, Serialized)
{
Debug = "DPTC: Using normal SOC DPTC Settings."
Name (DEFB, Buffer (0x25)
{
...
})
_SB.ALIB
0x0C
DEFB
}
}
Scope (_SB)
{
Method (DTHL, 0, Serialized)
{
Debug = "DPTC: Using low/no battery mode SOC DPTC settings."
Name (THTL, Buffer (0x25)
{
...
})
_SB.ALIB
0x0C
THTL
}
}
```
If it's just for consistency's sake, I can add them, but it doesn't appear to be necessary.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67188
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e93d892b3b8016221812c8b9ec6c257dcf13ef5
Gerrit-Change-Number: 67188
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 01 Sep 2022 21:19:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment