Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43537 )
Change subject: soc/intel/common: Log CSE FW Status Registers before triggering recovery ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43537/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43537/2//COMMIT_MSG@9 PS2, Line 9: log
logs
Ack
https://review.coreboot.org/c/coreboot/+/43537/2/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/43537/2/src/soc/intel/common/block/... PS2, Line 158: printk(BIOS_DEBUG, "cse_lite: CSE status registers: HFSTS1:0x%x, HFSTS2:0x%x HFST3:0x%x\n",
Please add a space after the colon of the register names.
Ack