Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41770 )
Change subject: tests: Move cmocka binary into $(obj)
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41770/1/tests/Makefile.inc
File tests/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41770/1/tests/Makefile.inc@6
PS1, Line 6: cmockaobj = $(objutil)/cmocka
One side effect of this change is that "make clean" will remove cmocka library. […]
We have distclean, but even that probably doesn't touch 3rdparty repositories. All in all, we try to keep sources and object files separate, and if people want a clean tree, then stuff gets rebuilt - simple as that :-)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41770
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5670d9b661891262ad936980f63fa93b07c27e95
Gerrit-Change-Number: 41770
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 May 2020 11:36:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jan Dabros
jsd@semihalf.com
Gerrit-MessageType: comment