HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37935 )
Change subject: src/*.asl: Remove _HID / _ADR objects
......................................................................
Patch Set 2:
Patch Set 2: Code-Review-1
This is untested and no objective was given why one of _ADR or _HID was preferred over the other. It's unclear if there are OS that requires one of them to be present.
On latest platforms those devices can be placed in ACPI or PCI mode.
Making it even worse there seem to be auto-detection features: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...
date Oct 24, 2014 :
"The PCI config space is required for many "legacy" OSs"
so should we support Windows 3.11 :D ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37935
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I949393558f5af66689c167b2e593a1461f641962
Gerrit-Change-Number: 37935
Gerrit-PatchSet: 2
Gerrit-Owner: Jonas Moehle
ad-min@mailbox.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jonas Moehle
ad-min@mailbox.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 30 Dec 2019 10:55:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
