[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/smm: Remove redundant masking op

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34797 )

Change subject: soc/intel/common/smm: Remove redundant masking op
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34797/1/src/soc/intel/common/block/... 
File src/soc/intel/common/block/smm/smitraphandler.c:

https://review.coreboot.org/c/coreboot/+/34797/1/src/soc/intel/common/block/... 
PS1, Line 109: data =
> Coverity will likely complain now that this assignment isn't used, which makes me wonder why pcr_rea […]

Hm, that's a good point.  What do you think about:
(void)pcr_read32(PID_PSTH, PCR_PSTH_TRPD);
possibly in both places?
Because pcr_read32 calls read32 which takes a volatile pointer, the compiler *shouldn't* optimize it away.  The (void) makes it clear this action is done purely for its side-effects.