Attention is currently required from: Simon Chou, TimLiu-SMCI, Jonathan Zhang, Ryback Hung, Paul Menzel, Angel Pons, Tim Chu.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71953 )
Change subject: soc/intel/common/block/fast_spi: Add SPI BIOS decode lock
......................................................................
Patch Set 8: -Code-Review
(1 comment)
File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/71953/comment/952d64f1_82131435
PS6, Line 467: pci_write_config32(dev, SPI_BIOS_DECODE_EN, bde);
Done
Sorry, looking back at this I think what Paul meant is:
`pci_or_config32(dev, SPI_BIOS_DECODE_EN, SPI_BIOS_DECODE_LOCK);`
Then we can get rid of the `bde` variable and reduce the size of this function by 3 lines.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71953
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3366817b42a5878f16575698ebc546fa7852e285
Gerrit-Change-Number: 71953
Gerrit-PatchSet: 8
Gerrit-Owner: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Ryback Hung
ryback.hung@quantatw.com
Gerrit-Reviewer: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Attention: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Ryback Hung
ryback.hung@quantatw.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 06 Feb 2023 00:04:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Simon Chou
simonchou@supermicro.com.tw
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment