Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41209 )
Change subject: fw_config: Add firmware configuration interface ......................................................................
Patch Set 4:
(7 comments)
https://review.coreboot.org/c/coreboot/+/41209/4/src/include/fw_config.h File src/include/fw_config.h:
https://review.coreboot.org/c/coreboot/+/41209/4/src/include/fw_config.h@2 PS4, Line 2: /* This file is part of the coreboot project. *
please remove
Done
https://review.coreboot.org/c/coreboot/+/41209/4/src/include/fw_config.h@8 PS4, Line 8: #include <types.h>
this is not used.
swapped with stdbool.h
https://review.coreboot.org/c/coreboot/+/41209/4/src/include/fw_config.h@9 PS4, Line 9: #include <static.h>
maybe <device/device.h> is missing in one of you files ? […]
this file is pretty much useless without static.h so I was trying to avoid having to include both every time, but I can move it to all the mainboards.
the dependency issue is at build time though, I need to figure out how to get make to run sconfig first every time.
https://review.coreboot.org/c/coreboot/+/41209/4/src/lib/fw_config.c File src/lib/fw_config.c:
https://review.coreboot.org/c/coreboot/+/41209/4/src/lib/fw_config.c@2 PS4, Line 2: /* This file is part of the coreboot project. */
please remove
Done
https://review.coreboot.org/c/coreboot/+/41209/4/src/lib/fw_config.c@6 PS4, Line 6: #include <cbfs.h>
not used? […]
needed for cbfs_boot_load_file() but some of the others were now stale after this was rewritten so they have been culled.
https://review.coreboot.org/c/coreboot/+/41209/4/src/lib/fw_config.c@11 PS4, Line 11: #include <string.h>
not used
Done
https://review.coreboot.org/c/coreboot/+/41209/4/src/lib/fw_config.c@12 PS4, Line 12: #include <types.h>
not used?
this is what was bringing in bool, but I guess I could include stdbool.h directly.