Attention is currently required from: Angel Pons, Keith Hui, Patrick Rudolph, Paul Menzel, Vlado Cibic.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73693?usp=email )
Change subject: mb/asus/p8z77-m[_pro]: Properly configure early serial
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS9:
Devicetrees of these two differ: '-M' enables a UART A, '-M PRO' enables a UART B.
Looking at pictures of these boards, they look different enough that this is not
unlikely.
How about splitting this? i.e. Remove dead code from '-M PRO' and add the select
to the '-M' in a separate patch?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73693?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I304fc1610740375b59121b6b8784122440795838
Gerrit-Change-Number: 73693
Gerrit-PatchSet: 9
Gerrit-Owner: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Vlado Cibic
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Vlado Cibic
Gerrit-Attention: Keith Hui
buurin@gmail.com
Gerrit-Comment-Date: Mon, 20 Nov 2023 17:16:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment