EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35175 )
Change subject: mb/google/drallion: Update gpio config for drallion
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35175/4/src/mainboard/google/dralli...
File src/mainboard/google/drallion/variants/drallion/gpio.c:
https://review.coreboot.org/c/coreboot/+/35175/4/src/mainboard/google/dralli...
PS4, Line 90: /* UART0_TXD */ PAD_CFG_NF(GPP_C9, NONE, DEEP, NF1), /* SERVOTX_UART */
We did this in early table, should we init again?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35175
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78f85a266eb42ea186ff896db5cde0a347339a71
Gerrit-Change-Number: 35175
Gerrit-PatchSet: 4
Gerrit-Owner: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Krzysztof M Sywula
krzysztof.m.sywula@intel.com
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-CC: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Comment-Date: Tue, 03 Sep 2019 08:30:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment