Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37351 )
Change subject: AGESA,binaryPI: Fix stack location on entry to romstage
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37351/1/src/drivers/amd/agesa/cache...
File src/drivers/amd/agesa/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/37351/1/src/drivers/amd/agesa/cache...
PS1, Line 46: mov $LAPIC_BASE_MSR, %ecx
SilverBack/AMD showed no interest to fix it for several months now. […]
Nothing we can do about it then, I guess. Isn't AP car teardown done by AGESA? What is the big deal here (sorry I am a little bit unaware)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37351
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ec84ae4e73ecca5034f799cdc2a5c1056ad8b74
Gerrit-Change-Number: 37351
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 29 Nov 2019 10:09:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment