[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer: Source Memory strap GPIOs from variant

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46234 )

Change subject: mb/google/volteer: Source Memory strap GPIOs from variant
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46234/3/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h:

https://review.coreboot.org/c/coreboot/+/46234/3/src/mainboard/google/voltee... 
PS3, Line 13: #define GPIO_MEM_CONFIG_0	GPP_C12
            : #define GPIO_MEM_CONFIG_1	GPP_C15
            : #define GPIO_MEM_CONFIG_2	GPP_C14
            : #define GPIO_MEM_CONFIG_3	GPP_D15
> I think instead of making a copy of GPIO_MEM_CONFIG_* in every variant/gpio. […]

+1 what Furquan said