Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35426 )
Change subject: mb/supermicro: convert x11ssh to variants-capable tree structure
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1...
File src/mainboard/supermicro/x11/Kconfig:
https://review.coreboot.org/c/coreboot/+/35426/2/src/mainboard/supermicro/x1...
PS2, Line 45: default 0xb00000 if VBOOT
Did this change on purpose?
That's not a change but an addition, but I just realized we can drop "if VBOOT" because for vboot the size is defined in fmap. I'm not sure why they have 0x9aa000 in their Kconfig. At least x11ssh and x11ssm have a bios region of 0xb00000 but as I don't want to change the behaviour/effective config in this CR I left it as is but moved this to the variant's Kconfig.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35426
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8dc4240ae042760a845e890b923ad40478bb8e29
Gerrit-Change-Number: 35426
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 16 Sep 2019 16:13:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment