Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41605 )
Change subject: drivers/ocp/ipmi: Add ipmi POST start/end command
......................................................................
Patch Set 4:
(2 comments)
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/41605/1/src/drivers/ocp/ipmi/ipmi_o...
File src/drivers/ocp/ipmi/ipmi_ocp.h:
https://review.coreboot.org/c/coreboot/+/41605/1/src/drivers/ocp/ipmi/ipmi_o...
PS1, Line 6: #define IPMI_NETFN_OEM 0x30
Let's add tabs and align to statements below.
Done
https://review.coreboot.org/c/coreboot/+/41605/1/src/drivers/ocp/ipmi/ipmi_o...
File src/drivers/ocp/ipmi/ipmi_ocp.c:
https://review.coreboot.org/c/coreboot/+/41605/1/src/drivers/ocp/ipmi/ipmi_o...
PS1, Line 28: return 1;
Let's include cb_err.h, and use CB_ERR, CB_SUCCESS.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41605
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide0e2a52876db555ed8b5e919215e85731fd80ed
Gerrit-Change-Number: 41605
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Rocky Phagura
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Jun 2020 02:03:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment