Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37919 )
Change subject: lib/malloc: Implement a simple free() only for last malloc()
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37919/7/src/lib/malloc.c
File src/lib/malloc.c:
https://review.coreboot.org/c/coreboot/+/37919/7/src/lib/malloc.c@60
PS7, Line 60: "pointing to the heap\n",__func__);
space required after that ',' (ctx:VxV)
Done
https://review.coreboot.org/c/coreboot/+/37919/9/src/lib/malloc.c
File src/lib/malloc.c:
https://review.coreboot.org/c/coreboot/+/37919/9/src/lib/malloc.c@31
PS9, Line 31: free_last_alloc_ptr = p;
Sorry. […]
I added the comment but the gaps could happen with the current implementation of malloc() even if we don't call free() right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37919
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d43cf54b79e6897cf6882335730b2310e4eae45
Gerrit-Change-Number: 37919
Gerrit-PatchSet: 10
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 27 Dec 2019 22:12:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment