Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37263?usp=email )
Change subject: mb/google: Add unaligned flag (%) sections that don't need alignment
......................................................................
Patch Set 16:
(1 comment)
Patchset:
PS16:
Because we couldn't get everyone aligned on the same page? […]
Couldn't we? Hmm, okay, too bad. Not adding any checks sounds like the worst option.
I think I was in the align-by-default camp, I think(?) you were too? Not sure who was strongly against it, I guess Patrick in CB:37262? I didn't really read that as insurmountable opposition though, he just stopped responding at some point, maybe we should've just gone ahead and landed the patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37263?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6aacf6265f552e3190782dd9a78e0612b8c3a55
Gerrit-Change-Number: 37263
Gerrit-PatchSet: 16
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 13 Jun 2023 19:30:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment