Attention is currently required from: Patrick Rudolph, Philipp Hug, ron minnich.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79949?usp=email )
Change subject: arch/riscv/boot.c: Add comment for clarity
......................................................................
Patch Set 1:
(1 comment)
File src/arch/riscv/boot.c:
https://review.coreboot.org/c/coreboot/+/79949/comment/1e1af7fc_211b139f :
PS1, Line 35: // tell OpenSBI to switch to Supervisor mode before jumping to payload
please use C style comments `/* `
It is a single line comment so I choose C99 single line comment style.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79949?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib62be0c2ff59361200df4c65f9aca5f7456a0ada
Gerrit-Change-Number: 79949
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Tue, 16 Jan 2024 15:03:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment