Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33045 )
Change subject: mb/apple/macbookair4_2: Add CMOS support
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/33045/2/src/mainboard/apple/macbookair4_2/cm...
File src/mainboard/apple/macbookair4_2/cmos.layout:
https://review.coreboot.org/#/c/33045/2/src/mainboard/apple/macbookair4_2/cm...
PS2, Line 50: # coreboot config options: EC
please remove commented options
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33045
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I369ed9aeff2098a4840918531be6a34cfc8d2a1e
Gerrit-Change-Number: 33045
Gerrit-PatchSet: 2
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 28 May 2019 16:00:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment