Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78288?usp=email )
Change subject: drivers/pc80/rtc/option.c: Stop resetting CMOS during s3 resume
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS4:
Agree, we shouldn't reset CMOS during S3 resume. […]
GM45 platforms with or without CONFIG(STATIC_OPTION_TABLE) always performs memory training and store the result in CMOS above 128 bytes on every boot, and read it during s3 resume, as shown in raminit_read_training() and raminit_write_training() of nb/intel/gm45/raminit_read_write_training.c.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78288?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I533e83f3b95f327b0e24f4d750f8812325b7770b
Gerrit-Change-Number: 78288
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 09 Oct 2023 15:14:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-MessageType: comment