Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42547 )
Change subject: cpu/intel/model_206ax: Add overclocking support ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42547/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42547/1//COMMIT_MSG@12 PS1, Line 12: Tested on Asus P8Z77-V LX2 with an i5-3330, CPU now runs at 3.4 GHz.
I checked the speed using /proc/cpuinfo while loading all CPU cores. […]
Expanded the commit message, also tested a Sandy Bridge i7-2600
https://review.coreboot.org/c/coreboot/+/42547/1//COMMIT_MSG@13 PS1, Line 13:
Having `n` overclocking bins means that the max turbo ratio is equal to the non-turbo ratio plus `n` […]
Mentioned the BWG in the commit message, and referenced it on a comment in the code
https://review.coreboot.org/c/coreboot/+/42547/1/src/cpu/intel/model_206ax/m... File src/cpu/intel/model_206ax/model_206ax_init.c:
https://review.coreboot.org/c/coreboot/+/42547/1/src/cpu/intel/model_206ax/m... PS1, Line 443: xe_init
IIRC, it means eXtreme Edition. […]
Added a comment explaining what this function is about.
https://review.coreboot.org/c/coreboot/+/42547/1/src/cpu/intel/model_206ax/m... PS1, Line 449: printk(BIOS_DEBUG, "XE: not overriding Turbo Ratio limits\n");
The idea is that this function always prints one line when executed. […]
I updated the comment above it, but left the printk as-is for now while waiting for updates.
https://review.coreboot.org/c/coreboot/+/42547/1/src/cpu/intel/model_206ax/m... PS1, Line 481: printk(BIOS_NOTICE, "done.\n");
Uh, this should only run once, but it runs for all CPU cores... […]
Removed the printk after wrmsr.