Attention is currently required from: Christian Walter, Maximilian Brune, Lean Sheng Tan, David Milosevic.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68222 )
Change subject: mb/prodrive/atlas: Disable C-States & cTDP ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68222/comment/78a6b3ea_37ed8b40 PS1, Line 9: required "required" sounds wrong here. How about:
As Atlas is targeted towards industrial use cases:
https://review.coreboot.org/c/coreboot/+/68222/comment/f8cebabe_06453423 PS1, Line 11: - Disable all C-states other than C0/C1 for CPU and package Maybe add Kconfig options, so that it's easy to re-enable them for testing?
The main source of "annoyance" is that enabling SaGv (a power saving feature) and disabling C-states (another power saving feature) at the same time makes no sense outside of testing environments. In any case, this will probably end up being runtime configurable.