Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39111 )
Change subject: soc/intel/tigerlake: Add Jasper lake GPIO support ......................................................................
Patch Set 16:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39111/15/src/soc/intel/tigerlake/in... File src/soc/intel/tigerlake/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/39111/15/src/soc/intel/tigerlake/in... PS15, Line 41: /* Common macro definition for gpio_op.asl file */
No Furquan, these marcros are not defined in another header file. […]
That is not really true:
GPIORXSTATE_MASK --> PAD_CFG0_RX_STATE (https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/common/bloc...)
GPIORXSTATE_SHIFT --> PAD_CFG0_RX_STATE_BIT (https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/common/bloc...)
and so on.