Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32797
Change subject: soc/intel/skylake: Correct GPIO pointer assignment ......................................................................
soc/intel/skylake: Correct GPIO pointer assignment
We need to store the acpi_gpio struct, not save its address.
Found-by: Clang Static Analyzer Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: I41c8bf10ce72bec736da97ccc33f9ada49804dc1 --- M src/soc/intel/skylake/sd.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/32797/1
diff --git a/src/soc/intel/skylake/sd.c b/src/soc/intel/skylake/sd.c index 12c6abe..571d3e7 100644 --- a/src/soc/intel/skylake/sd.c +++ b/src/soc/intel/skylake/sd.c @@ -35,7 +35,7 @@ gpio->pin_count = 1; gpio->pins[0] = config->sdcard_cd_gpio_default; } else - gpio = &config->sdcard_cd_gpio; + *gpio = config->sdcard_cd_gpio;
return 0; }