[coreboot-gerrit] Change in coreboot[master]: soc/intel/cnl: Allow enabling/disabling Chap device

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44740 )

Change subject: soc/intel/cnl: Allow enabling/disabling Chap device
......................................................................

Patch Set 14:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44740/14/src/soc/intel/cannonlake/f... 
File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/44740/14/src/soc/intel/cannonlake/f... 
PS14, Line 532: 	tconfig->ChapDeviceEnable = is_dev_enabled(dev);
> CFL FSP uses the same polarity for CHAP, Camarillo, IPU and GNA, and this approach is correct.

@Nico wdym? FSP header says "Enable: Device  7 enabled, Disable (Default): Device 7 disabled", which is pretty clear IMO. However, I'm still not sure if we want to have the chap device in the devicetree instead of Kconfig/cmos