Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34948 )
Change subject: superio: nuvoton: add a driver for nct668xd ......................................................................
Patch Set 2:
(2 comments)
haven't fully reviewed the patch yet
https://review.coreboot.org/c/coreboot/+/34948/2/src/superio/nuvoton/nct668x... File src/superio/nuvoton/nct668xd/Kconfig:
https://review.coreboot.org/c/coreboot/+/34948/2/src/superio/nuvoton/nct668x... PS2, Line 21: config SUPERIO_NUVOTON_NCT668XD_COM_A : bool : depends on SUPERIO_NUVOTON_NCT668XD : default n the corresponding part in the nuvoton common code isn't in this patch
https://review.coreboot.org/c/coreboot/+/34948/2/src/superio/nuvoton/nct668x... File src/superio/nuvoton/nct668xd/superio.c:
https://review.coreboot.org/c/coreboot/+/34948/2/src/superio/nuvoton/nct668x... PS2, Line 46: pnp_enable_resources this conflicts with the second warning from the datasheet you mentioned in a comment in the header file. This function calls pnp_set_enable which sets or clears the corresponding bit in register 0x30 of the corresponding LDN