Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46731 )
Change subject: soc/intel/broadwell/cpu.c: Re-add `configure_thermal_target` ......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46731/7/src/soc/intel/broadwell/cpu... File src/soc/intel/broadwell/cpu.c:
https://review.coreboot.org/c/coreboot/+/46731/7/src/soc/intel/broadwell/cpu... PS7, Line 293: d configure_thermal_target(void) : { : config_t *conf; : struct device *lapic; : msr_t msr; : : /* Find pointer to CPU configuration */ : lapic = dev_find_lapic(SPEEDSTEP_APIC_MAGIC); : if (!lapic || !lapic->chip_info) : return; : conf = lapic->chip_info; : : /* Set TCC activation offset if supported */ : msr = rdmsr(MSR_PLATFORM_INFO); : if ((msr.lo & (1 << 30)) && conf->tcc_offset) { : msr = rdmsr(MSR_TEMPERATURE_TARGET); : msr.lo &= ~(0xf << 24); /* Bits 27:24 */ : msr.lo |= (conf->tcc_offset & 0xf) << 24; : wrmsr(MSR_TEMPERATURE_TARGET, msr); : } : } should be moved to cpu/common later