[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: Add ENABLE_DISPLAY_OVER_EXT_PCIE_GFX kconfig

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33738 )

Change subject: soc/intel/icelake: Add ENABLE_DISPLAY_OVER_EXT_PCIE_GFX kconfig
......................................................................

Patch Set 11:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33738/11/src/soc/intel/icelake/Kcon... 
File src/soc/intel/icelake/Kconfig:

https://review.coreboot.org/c/coreboot/+/33738/11/src/soc/intel/icelake/Kcon... 
PS11, Line 210: 	select ALWAYS_LOAD_OPROM
> Why is this "required" for external GFX?

should_load_oprom()is required to execute pci based oprom

https://review.coreboot.org/c/coreboot/+/33738/11/src/soc/intel/icelake/Kcon... 
PS11, Line 211: 	select FRAMEBUFFER_SET_VESA_MODE if CHROMEOS
> Isn't this independent from the external GFX choice?

yes, its kind of, VGA_ROM_RUN default loads text mode which might not work with depthcharge
> Would internal graphics work in text mode with Chromeos?

no, it doesn't work