Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38322 )
Change subject: Revert "security/intel/stm: Add STM support"
......................................................................
Patch Set 1:
(3 comments)
does it help to guard the three things I point at with a CONFIG(STM)?
https://review.coreboot.org/c/coreboot/+/38322/1/src/cpu/x86/mp_init.c
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/38322/1/src/cpu/x86/mp_init.c@a1056
PS1, Line 1056: state->smm_save_state_size =
this could be guarded by CONFIG_STM
https://review.coreboot.org/c/coreboot/+/38322/1/src/cpu/x86/smm/smm_stub.S
File src/cpu/x86/smm/smm_stub.S:
https://review.coreboot.org/c/coreboot/+/38322/1/src/cpu/x86/smm/smm_stub.S@...
PS1, Line 47: num_cpus:
these fields could be guarded
https://review.coreboot.org/c/coreboot/+/38322/1/src/cpu/x86/smm/smm_stub.S@...
PS1, Line 99: /* gdt selector 0x18, flat code segment (64-bit) */
and these selectors could be guarded by CONFIG_STM.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38322
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6268229c3e714a246b97a45538af908861acd258
Gerrit-Change-Number: 38322
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 06 Feb 2020 10:05:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment