build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32076 )
Change subject: src/mainboard/protectli/vault: Add FW2B and FW4B boards support ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/#/c/32076/7/src/mainboard/protectli/vault/gpio.c File src/mainboard/protectli/vault/gpio.c:
https://review.coreboot.org/#/c/32076/7/src/mainboard/protectli/vault/gpio.c... PS7, Line 231: NATIVE_FUNC(1, P_1K_H, NA), /* 10 PMU_WAKE_B */ please, no space before tabs
https://review.coreboot.org/#/c/32076/7/src/mainboard/protectli/vault/irqrou... File src/mainboard/protectli/vault/irqroute.h:
https://review.coreboot.org/#/c/32076/7/src/mainboard/protectli/vault/irqrou... PS7, Line 22: #define PCI_DEV_PIRQ_ROUTES \ Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/#/c/32076/7/src/mainboard/protectli/vault/irqrou... PS7, Line 33: #define PIRQ_PIC_ROUTES \ Macros with complex values should be enclosed in parentheses