[coreboot-gerrit] Change in ...coreboot[master]: hatch: Fix pen eject polarity

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33427 )

Change subject: hatch: Fix pen eject polarity
......................................................................

Patch Set 1:

(1 comment)
> Patch Set 1:
>
> (1 comment)

https://review.coreboot.org/#/c/33427/1/src/mainboard/google/hatch/variants/... 
File src/mainboard/google/hatch/variants/hatch/overridetree.cb:

https://review.coreboot.org/#/c/33427/1/src/mainboard/google/hatch/variants/... 
PS1, Line 89: 				register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)"
> Maybe we set EDGE_HIGH here and let kernel set as both? I think this active high actually. […]

The reason I left it this way is for documentation purposes: someone looking at the device tree doesn't have to wonder why it's only set here to generate interrupts on one edge, and know that the kernel driver (which may change) is setting up for both edges regardless.