Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34839 )
Change subject: intel/smm/gen1: Split alternative SMRR register function
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34839/2/src/cpu/intel/smm/gen1/smmr...
File src/cpu/intel/smm/gen1/smmrelocate.c:
https://review.coreboot.org/c/coreboot/+/34839/2/src/cpu/intel/smm/gen1/smmr...
PS2, Line 86: if (!((msr.lo & SMRR_ENABLE)
: && (msr.lo & FEATURE_CONTROL_LOCK_BIT))) {
: printk(BIOS_WARNING,
: "SMRR not enabled, skip writing SMRR...\n");
Very minor: Can fit in 96 chars
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34839
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I208ac84fdf5d8041a1901cc2331769cd3a8d6bea
Gerrit-Change-Number: 34839
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 14 Aug 2019 15:40:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment