Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39821 )
Change subject: nb/i945: Split raminit into desktop and mobile version
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39821/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39821/8//COMMIT_MSG@9
PS8, Line 9: Split up ramint.c to make maintenance easier.
Reference the datasheet, and mention what parts differ mainly to justify a split?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39821
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I763efcff97ee3d0f1c3df62102f22ee3b3f6a0fc
Gerrit-Change-Number: 39821
Gerrit-PatchSet: 8
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Mar 2020 18:08:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment