[coreboot-gerrit] [S] Change in coreboot[main]: mb/samsung/stumpy: Use CFR setup menu to manage options

[Angel Pons (Code Review)]

Attention is currently required from: Matt DeVillier.

Angel Pons has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/87404?usp=email )

Change subject: mb/samsung/stumpy: Use CFR setup menu to manage options
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

File src/mainboard/samsung/stumpy/Kconfig:

https://review.coreboot.org/c/coreboot/+/87404/comment/60e29d17_b5973cc0?usp... :
PS2, Line 35: config UEFI_CFR_SYSTEM_OPTIONS
            : 	bool "Use UEFI setup menu to manage system configuration"
            : 	select DRIVERS_EFI_VARIABLE_STORE
            : 	select DRIVERS_OPTION_CFR
            : 	select UDK_2017_BINDING
            : 	default y if PAYLOAD_EDK2 && SMMSTORE
            : 	default n
            : 
Ideally, this should be set up so that selecting CFR as the option backend would select these. And there should be a way to enable CFR by default for `PAYLOAD_EDK2 && SMMSTORE`.

I'm afraid I'm currently too tired to think this through, so I'll have to revisit this tomorrow after sleeping.