Attention is currently required from: Tarun Tuli, John Zhao, Kapil Porwal, Tim Wawrzynczak, Sumeet R Pawnikar.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67789 )
Change subject: soc/intel/meteorlake: Provide mitigation support for CNVi RFI
......................................................................
Patch Set 8:
(1 comment)
File src/soc/intel/meteorlake/romstage/fsp_params.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-162296):
https://review.coreboot.org/c/coreboot/+/67789/comment/dce7f7f8_f12d74e9
PS8, Line 241: if (CONFIG(SOC_INTEL_CRASHLOG)) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67789
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87110bc10b98a27a8f274680597b15a1df488824
Gerrit-Change-Number: 67789
Gerrit-PatchSet: 8
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Thu, 03 Nov 2022 16:26:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment