[coreboot-gerrit] [XS] Change in coreboot[main]: mb/google/fatcat: Enable FSP_UGOP_EARLY_SIGN_OF_LIFE

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87236?usp=email )

Change subject: mb/google/fatcat: Enable FSP_UGOP_EARLY_SIGN_OF_LIFE
......................................................................

mb/google/fatcat: Enable FSP_UGOP_EARLY_SIGN_OF_LIFE

This patch moves eSOL enablement from the SoC level to the mainboard level. This gives the mainboard the option to not use eSOL if it's not supported.

The FSP_UGOP_EARLY_SIGN_OF_LIFE Kconfig option is now enabled for the Fatcat and Felino boards.

This option was previously enabled at the SoC level for Pantherlake,
but is now being enabled specifically for these mainboards.

BUG=b:400550435
TEST=Build the Fatcat and Felino targets. Verify that the eSOL works
fine.

Change-Id: Ie0cf5b00f75071640475d61420824cb2b89b4103
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/87236
Reviewed-by: Pranava Y N 
Tested-by: build bot (Jenkins) 
Reviewed-by: Kapil Porwal 
Reviewed-by: Jayvik Desai 
---
M src/mainboard/google/fatcat/Kconfig
M src/soc/intel/pantherlake/Kconfig
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jayvik Desai: Looks good to me, approved
  Kapil Porwal: Looks good to me, approved
  build bot (Jenkins): Verified
  Pranava Y N: Looks good to me, approved

diff --git a/src/mainboard/google/fatcat/Kconfig b/src/mainboard/google/fatcat/Kconfig
index 2679b14..08a5eba 100644
--- a/src/mainboard/google/fatcat/Kconfig
+++ b/src/mainboard/google/fatcat/Kconfig
@@ -62,6 +62,7 @@
    select DRIVERS_GENERIC_BAYHUB_LV2
    select DRIVERS_GENERIC_MAX98357A
    select DRIVERS_INTEL_TOUCH
+	select FSP_UGOP_EARLY_SIGN_OF_LIFE

config BOARD_GOOGLE_FATCAT
    select BOARD_GOOGLE_MODEL_FATCAT
@@ -81,6 +82,7 @@

config BOARD_GOOGLE_FELINO
    select BOARD_GOOGLE_BASEBOARD_FATCAT
+	select FSP_UGOP_EARLY_SIGN_OF_LIFE
    select HAVE_SLP_S0_GATE
    select MAINBOARD_HAS_GOOGLE_STRAUSS_KEYBOARD

diff --git a/src/soc/intel/pantherlake/Kconfig b/src/soc/intel/pantherlake/Kconfig
index a884631..36417db 100644
--- a/src/soc/intel/pantherlake/Kconfig
+++ b/src/soc/intel/pantherlake/Kconfig
@@ -17,7 +17,6 @@
    select FAST_SPI_SUPPORTS_EXT_BIOS_WINDOW
    select FSP_COMPRESS_FSP_S_LZ4
    select FSP_M_XIP
-	select FSP_UGOP_EARLY_SIGN_OF_LIFE
    select FSP_USES_CB_DEBUG_EVENT_HANDLER
    select FSPS_HAS_ARCH_UPD
    select GENERIC_GPIO_LIB