Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42889 )
Change subject: RFC: soc/amd/picasso: Enable paging for boot ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42889/2/src/arch/x86/tables.c File src/arch/x86/tables.c:
https://review.coreboot.org/c/coreboot/+/42889/2/src/arch/x86/tables.c@213 PS2, Line 213: paging_enable_pae is this ok with nothing written to cr3?
https://review.coreboot.org/c/coreboot/+/42889/2/src/device/oprom/realmode/x... File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/42889/2/src/device/oprom/realmode/x... PS2, Line 308: paging_disable_pae(); Can this be done in a different patchset?
https://review.coreboot.org/c/coreboot/+/42889/2/src/soc/amd/picasso/page_ma... File src/soc/amd/picasso/page_map.txt:
https://review.coreboot.org/c/coreboot/+/42889/2/src/soc/amd/picasso/page_ma... PS2, Line 3: 0xcbd0b000, 0xd0000000, WB, # RAM for CBMEM and FSP should this not be determined at runtime?