Attention is currently required from: Kangheui Won, Reka Norman, Eric Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62779 )
Change subject: mb/google/brya: Remove mainboard.asl ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/mainboard.c:
https://review.coreboot.org/c/coreboot/+/62779/comment/6d4c87a4_19452f01 PS3, Line 115: acpigen_write_if_lequal_op_int(ARG0_OP, 1); : if (CONFIG(HAVE_SLP_S0_GATE)) : acpigen_soc_clear_tx_gpio(GPIO_SLP_S0_GATE); : variant_generate_s0ix_hook(S0IX_ENTRY); : acpigen_write_else(); : if (CONFIG(HAVE_SLP_S0_GATE)) : acpigen_soc_set_tx_gpio(GPIO_SLP_S0_GATE); : variant_generate_s0ix_hook(S0IX_EXIT); : acpigen_write_if_end(); suggestion (adding {} only) ``` acpigen_write_if_lequal_op_int(ARG0_OP, 1); { if (CONFIG(HAVE_SLP_S0_GATE)) acpigen_soc_clear_tx_gpio(GPIO_SLP_S0_GATE); variant_generate_s0ix_hook(S0IX_ENTRY); } acpigen_write_else(); { if (CONFIG(HAVE_SLP_S0_GATE)) acpigen_soc_set_tx_gpio(GPIO_SLP_S0_GATE); variant_generate_s0ix_hook(S0IX_EXIT); } acpigen_write_if_end(); ```