Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30826 )
Change subject: security/tpm/tss/tcg-2.0: Add TPM2 function tlcl_getcapability()
......................................................................
Patch Set 16:
(2 comments)
https://review.coreboot.org/#/c/30826/15/src/security/tpm/tss/tcg-2.0/tss.c
File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/#/c/30826/15/src/security/tpm/tss/tcg-2.0/tss.c@...
PS15, Line 373: * Please note that the capabilityData is not unmarshalled.
... […]
Comment is about input parameter.
https://review.coreboot.org/#/c/30826/15/src/security/tpm/tss/tcg-2.0/tss.c@...
PS15, Line 403: sizeof(TPMI_YES_NO) - sizeof(struct tpm_header));
I don't understand what this is for... […]
Need the information of the GetCapability only. For this reason the size of this data needs to be known.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30826
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85e1bd2822aa6e7fd95ff2b9faa25cf183e6de37
Gerrit-Change-Number: 30826
Gerrit-PatchSet: 16
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Andrey Pronin
apronin@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 21 Jun 2019 13:57:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment