6 Nov
2018
6 Nov
'18
2:55 p.m.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/29429 )
Change subject: mb/google/poppy/variant/nocturne: use PLTRST for GPP_C11 ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/#/c/29429/2/src/mainboard/google/poppy/variants/... PS2, Line 138: PLTRST
I was wondering the same thing when I added sarien/arcada. […]
I think you're correct. GPP_C9 did not like being set to PLTRST, it kept device from being able to enter S3.
--
To view, visit https://review.coreboot.org/29429
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I008532fce963c51a435378001440ac72b5ebfffc
Gerrit-Change-Number: 29429
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali caveh@google.com
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 06 Nov 2018 21:55:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No