Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42078 )
Change subject: src/ec/google/chromeec: Get Type-C Mux info from EC (TCPM) ......................................................................
Patch Set 12:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42078/5/src/ec/google/chromeec/ec.h File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/42078/5/src/ec/google/chromeec/ec.h... PS5, Line 33: * usb capability, dp capability, cable type, etc
Please use spaces for alignment.
Done
https://review.coreboot.org/c/coreboot/+/42078/2/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/42078/2/src/ec/google/chromeec/ec.c... PS2, Line 1531: uint8_t num_ports; : int ret; : struct chromeec_command cmd; : int i; : : ret = google_chromeec_get_num_pd_ports(&num_ports); : if (ret < 0) : return -1; : : for (i = 0; i < num_ports; i++)
ok sure I'll remove it in the next update
Done
https://review.coreboot.org/c/coreboot/+/42078/8/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/42078/8/src/ec/google/chromeec/ec.c... PS8, Line 1381: EC_CMD_CHARGE_PORT_COUNT
EC_CMD_USB_PD_PORTS
Done
https://review.coreboot.org/c/coreboot/+/42078/8/src/ec/google/chromeec/ec.c... PS8, Line 1490: reserved
we're planning to remove this hack.
Will update this when that is fixed