Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36342 )
Change subject: sb/intel/common/spi: Add Baytrail/Braswell support
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36342/3/src/southbridge/intel/commo...
File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/c/coreboot/+/36342/3/src/southbridge/intel/commo...
PS3, Line 281: uint32_t sbase;
Please make use of `uintptr_t`. […]
Done
https://review.coreboot.org/c/coreboot/+/36342/3/src/southbridge/intel/commo...
PS3, Line 292: sbase = pci_read_config32(dev, 0x52);
Would using defines (like SBASE in SoC) make code mode readable?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36342
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib14f185eab8bf708ad82b06c7a7ce586744318fd
Gerrit-Change-Number: 36342
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Mon, 28 Oct 2019 16:54:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment