Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Ravindra, Subrata Banik, Andrey Petrov, Patrick Rudolph. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57343 )
Change subject: drivers/intel/fsp2_0: Allow `mp_startup_all_cpus()` to run serially ......................................................................
Patch Set 4:
(11 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57343/comment/98a614d1_87834b9a PS4, Line 9: EDK2 What does EDK2 have to do with coreboot?
https://review.coreboot.org/c/coreboot/+/57343/comment/8ba7e5fa_ef162f68 PS4, Line 10: would execute should be executed
https://review.coreboot.org/c/coreboot/+/57343/comment/74b47f39_6a4698f6 PS4, Line 11: meaning execute meaning to execute
https://review.coreboot.org/c/coreboot/+/57343/comment/a3f2e3ca_c391298d PS4, Line 10: as `SingleThread` sets : to 'true' meaning execute the function one by one (serially) or sets to : 'false' meaning execute the function simultaneously Maybe start a new sentence.
https://review.coreboot.org/c/coreboot/+/57343/comment/361617cd_68bf02ad PS4, Line 12: meaning execute meaning to execute
https://review.coreboot.org/c/coreboot/+/57343/comment/501300bc_8d7a8bd4 PS4, Line 14: has designed *allows* or *was designed*?
https://review.coreboot.org/c/coreboot/+/57343/comment/a71f9ae5_03c66a63 PS4, Line 17: specifies specify
https://review.coreboot.org/c/coreboot/+/57343/comment/3876a3c3_4023267b PS4, Line 18: results into results in
https://review.coreboot.org/c/coreboot/+/57343/comment/11bbfec2_eaa0f6f2 PS4, Line 19: acquire spin lock acquiring a spin lock
https://review.coreboot.org/c/coreboot/+/57343/comment/5768e96e_48ce9792 PS4, Line 19: coherency issue a coherency issue
https://review.coreboot.org/c/coreboot/+/57343/comment/d87c0f06_707aafd0 PS4, Line 20: data structure in multiprocessor environment. How does the coherency issue manifest itself? Please describe the problem.