Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45848 )
Change subject: soc/intel/xeon_sp/skx: Make devicetree config and ops generic
......................................................................
Patch Set 3: -Code-Review
Patch Set 3: Code-Review-2
I broke static.c with this change. The cpx/chip.h isn't automatically added. I need to figure out if those need to be combined first or if they can stay separated in the directories but still picked up by the build.
Ugh, I can see why...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45848
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4509d54371aca02cc96f7a18821fac8ce5404aa
Gerrit-Change-Number: 45848
Gerrit-PatchSet: 3
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 02 Oct 2020 22:37:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment