26 Feb
2021
26 Feb
'21
10:59 p.m.
Attention is currently required from: Angel Pons, Arthur Heymans. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42631 )
Change subject: sb/intel/lynxpoint/me.c: Reorder functions ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/southbridge/intel/lynxpoint/me.c:
https://review.coreboot.org/c/coreboot/+/42631/comment/309f09cf_be4d05a1 PS5, Line 758: * Return 1 to indicate success (send LOCK+EOP with NOACK) I see no such thing?
--
To view, visit https://review.coreboot.org/c/coreboot/+/42631
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3143f07ed845e0c6b1444817029a437db3b959e3
Gerrit-Change-Number: 42631
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 26 Feb 2021 22:59:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment