Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37490 )
Change subject: soc/amd/picasso: Add bootblock support ......................................................................
Patch Set 13:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37490/12//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37490/12//COMMIT_MSG@12 PS12, Line 12: All Picasso designs will now use a bootblock as their first stage.
there is a missing sentence before this as to why we flipped back to using bootblock from hybrid rom […]
Done
https://review.coreboot.org/c/coreboot/+/37490/12/src/soc/amd/picasso/Makefi... File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37490/12/src/soc/amd/picasso/Makefi... PS12, Line 186: # TODO(b/154957411): Refactor amdfwtool to extract the address and size from
I set a due date of 5/15, and assigned.
Ack
https://review.coreboot.org/c/coreboot/+/37490/12/src/soc/amd/picasso/bootbl... File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37490/12/src/soc/amd/picasso/bootbl... PS12, Line 27: printk(BIOS_DEBUG, "Family_Model: %08x\n", val);
follow-on for later - can we identify the SOC and print? I think this is in our private branch but w […]
That can be added once we port over the soc_utils