Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39280 )
Change subject: soc/intel/tigerlake: Correct FSP log interface for JSL ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39280/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39280/5//COMMIT_MSG@13 PS5, Line 13: ACE_TRACEHUB selection and set debuginterface flag accordingly.
https://review.coreboot.org/c/coreboot/+/39280/5/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/39280/5/src/soc/intel/tigerlake/chi... PS5, Line 200: Disable, 1: Target Debugger Mode, 2: Host Debugger Mode I think the description in last line says it all, can skip the above lines.
https://review.coreboot.org/c/coreboot/+/39280/5/src/soc/intel/tigerlake/chi... PS5, Line 197: *Select 'Host Debugger' if Trace Hub is used with host debugger tool : *or 'Target Debugger' if Trace Hub is used by target debugger software : *or 'Disable' trace hub functionality. : *0: space after *